[webkit-reviews] review granted: [Bug 218864] [iOS][FCR] Add new look for progress bars : [Attachment 414275] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 18 12:11:05 PST 2020
Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 218864: [iOS][FCR] Add new look for progress bars
https://bugs.webkit.org/show_bug.cgi?id=218864
Attachment 414275: Patch
https://bugs.webkit.org/attachment.cgi?id=414275&action=review
--- Comment #9 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 414275
--> https://bugs.webkit.org/attachment.cgi?id=414275
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=414275&action=review
The new patch LGTM (just a minor comment).
It looks like Darin reviewed it already as well.
> Source/WebCore/rendering/RenderThemeIOS.h:116
> + Seconds animationRepeatIntervalForProgressBar(RenderProgress&) const
final;
Nit - can this take a `const RenderProgress&`?
More information about the webkit-reviews
mailing list