[webkit-reviews] review granted: [Bug 219102] [iOS] beforeunload event does not fire in MobileSafari : [Attachment 414464] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 18 11:54:48 PST 2020


Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 219102: [iOS] beforeunload event does not fire in MobileSafari
https://bugs.webkit.org/show_bug.cgi?id=219102

Attachment 414464: Patch

https://bugs.webkit.org/attachment.cgi?id=414464&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 414464
  --> https://bugs.webkit.org/attachment.cgi?id=414464
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414464&action=review

r=me

> Source/WebCore/ChangeLog:9
> +	   MobileSafari on iOS does implement WKUIDelegate's
runJavaScriptAlertPanelWithMessage because

does not

> Source/WebCore/ChangeLog:16
> +

Might be worth mentioning that iOS already fires the unload event, so running
an event at this time is not a significant change in policy.


More information about the webkit-reviews mailing list