[webkit-reviews] review granted: [Bug 219089] Clean up some code in SharedDisplayListHandle : [Attachment 414452] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 219089: Clean up some code in SharedDisplayListHandle
https://bugs.webkit.org/show_bug.cgi?id=219089

Attachment 414452: Patch

https://bugs.webkit.org/attachment.cgi?id=414452&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 414452
  --> https://bugs.webkit.org/attachment.cgi?id=414452
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414452&action=review

r=me

> Source/WebKit/Shared/SharedDisplayListHandle.h:40
> +    static constexpr size_t reservedCapacityAtStart()

We usually say "reserved capacity" to mean unused bytes. But these bytes are
used -- by the DisplayListSharedMemoryHeader.

How about just calling this "headerSize"?

> Source/WebKit/Shared/SharedDisplayListHandle.h:42
> +	   return
roundUpToMultipleOf<sizeof(uint64_t)>(sizeof(DisplayListSharedMemoryHeader));

Slightly better to use std::max_align_t instead of sizeof(uint64_t).