[webkit-reviews] review granted: [Bug 217747] Introduce new download API : [Attachment 414415] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 217747: Introduce new download API
https://bugs.webkit.org/show_bug.cgi?id=217747

Attachment 414415: Patch

https://bugs.webkit.org/attachment.cgi?id=414415&action=review




--- Comment #19 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 414415
  --> https://bugs.webkit.org/attachment.cgi?id=414415
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414415&action=review

Besides fixing EWSs, etc... seems fine.

Except for calling downloads "web views"

> Source/WebKit/UIProcess/API/Cocoa/WKDownloadDelegate.h:57
> + @param download The web view that received the authentication challenge.

Download

> Source/WebKit/UIProcess/API/Cocoa/WKDownloadDelegate.h:82
> + @param download The web view that has written data.

Download

> Source/WebKit/UIProcess/API/Cocoa/WKDownloadDelegate.h:93
> + @param download The web view that finished.

Download

> Source/WebKit/UIProcess/API/Cocoa/WKDownloadDelegate.h:98
> + @param download The web view that has failed.

Download