[webkit-reviews] review denied: [Bug 218975] [css-flex] Images as flex items should use the overridingLogicalHeight when defined to compute the logical width : [Attachment 414322] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has denied Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 218975: [css-flex] Images as flex items should use the
overridingLogicalHeight when defined to compute the logical width
https://bugs.webkit.org/show_bug.cgi?id=218975

Attachment 414322: Patch

https://bugs.webkit.org/attachment.cgi?id=414322&action=review




--- Comment #3 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 414322
  --> https://bugs.webkit.org/attachment.cgi?id=414322
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414322&action=review

> Source/WebCore/rendering/RenderReplaced.cpp:527
> +	       ASSERT(intrinsicRatio);

intrisicRatio can be zero, so this ASSERT will crash (like it's happening on
the debug EWS), Shouldn't we add it in the previous check?