[webkit-reviews] review granted: [Bug 219021] Add a default action for SpeechRecognition permission request : [Attachment 414306] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 219021: Add a default action for SpeechRecognition permission request
https://bugs.webkit.org/show_bug.cgi?id=219021

Attachment 414306: Patch

https://bugs.webkit.org/attachment.cgi?id=414306&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 414306
  --> https://bugs.webkit.org/attachment.cgi?id=414306
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414306&action=review

> Source/WebKit/UIProcess/Cocoa/UserMediaPermissionRequestProxy.mm:29
>  #if ENABLE(MEDIA_STREAM)

UserMediaPermissionRequestProxy.mm can probably be removed if we move the alter
code in MediaPermissionUtilities.mm.

> Source/WebKit/UIProcess/MediaPermissionUtilities.h:77
> +template<> struct EnumTraits<WebKit::MediaPermissionType> {

Do we need to send this over IPC?

> Source/WebKit/UIProcess/WebPageProxy.cpp:10251
> +void WebPageProxy::decidePolicyForSpeechRecognitionPermission(const
WebCore::SecurityOrigin& origin, CompletionHandler<void(bool)>&&
completionHandler)

Maybe the name could be more descriptive here. I don't have a good name though.