[webkit-reviews] review granted: [Bug 218976] GraphicsContextGL should have robust multivalue getters : [Attachment 414313] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 218976: GraphicsContextGL should have robust multivalue getters
https://bugs.webkit.org/show_bug.cgi?id=218976

Attachment 414313: Patch

https://bugs.webkit.org/attachment.cgi?id=414313&action=review




--- Comment #19 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 414313
  --> https://bugs.webkit.org/attachment.cgi?id=414313
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414313&action=review

> Source/WebCore/platform/graphics/GraphicsTypesGL.h:72
> +    T& operator*() {  ASSERT(data); return *data; }

Extra space. Should these be release asserts?

> Source/WebCore/platform/graphics/GraphicsTypesGL.h:92
> +    T& operator[](size_t i) { ASSERT(data); ASSERT(i < bufSize); return
data[i]; }
> +    T& operator*() { ASSERT(data); return *data; }

Release asserts?

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:1973
> +    // FIXME: Bug in ANGLE bufSize validation for uniforms.

Reference a bug number?

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:1982
> +    // FIXME: Bug in ANGLE bufSize validation for uniforms.

Reference a bug number?

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:1991
> +    // FIXME: Bug in ANGLE bufSize validation for uniforms.

Reference a bug number?