[webkit-reviews] review granted: [Bug 218494] Release assertion failure in Optional<WebCore::SimpleRange>::operator* via CompositeEditCommand::moveParagraphs : [Attachment 414211] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 218494: Release assertion failure in
Optional<WebCore::SimpleRange>::operator* via
CompositeEditCommand::moveParagraphs
https://bugs.webkit.org/show_bug.cgi?id=218494

Attachment 414211: Patch

https://bugs.webkit.org/attachment.cgi?id=414211&action=review




--- Comment #22 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 414211
  --> https://bugs.webkit.org/attachment.cgi?id=414211
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414211&action=review

> Source/WebCore/editing/CompositeEditCommand.cpp:1403
> +    ASSERT(startOfParagraphToMove == endOfParagraphToMove ||
!endOfParagraphToMove.isNull());

This is harder to parse than (startOfParagraphToMove.isNull() &&
endOfParagraphToMove.isNull()) || endOfParagraphToMove.isNull()