[webkit-reviews] review granted: [Bug 219017] REGRESSION (r269824): YouTube media control bar sometimes flickers : [Attachment 414299] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 16 19:20:53 PST 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 219017: REGRESSION (r269824): YouTube media control bar sometimes flickers
https://bugs.webkit.org/show_bug.cgi?id=219017

Attachment 414299: Patch

https://bugs.webkit.org/attachment.cgi?id=414299&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 414299
  --> https://bugs.webkit.org/attachment.cgi?id=414299
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414299&action=review

> LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html:4
> +  <style type="text/css" media="screen">

No need for `type="text/css" media="screen"`

> LayoutTests/compositing/repaint/transparent-layer-repaint-expected.html:9
> +	   -webkit-transform: translateZ(0);

no prefix!

> LayoutTests/compositing/repaint/transparent-layer-repaint.html:9
> +	   -webkit-transform: translateZ(0);

No prefix.

> LayoutTests/compositing/repaint/transparent-layer-repaint.html:25
> +	       await UIHelper.ensurePresentationUpdate();

Maybe UIHelper.renderingUpdate()?

> LayoutTests/compositing/repaint/transparent-layer-repaint.html:27
> +	       await UIHelper.ensurePresentationUpdate();

Same


More information about the webkit-reviews mailing list