[webkit-reviews] review granted: [Bug 218912] [Media In GPU Process][MSE] Add infrastructure needed to run MediaPlayerPrivateMediaSourceAVFObjC in the GPU process : [Attachment 414286] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 218912: [Media In GPU Process][MSE] Add infrastructure needed to run
MediaPlayerPrivateMediaSourceAVFObjC in the GPU process
https://bugs.webkit.org/show_bug.cgi?id=218912

Attachment 414286: Patch

https://bugs.webkit.org/attachment.cgi?id=414286&action=review




--- Comment #13 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 414286
  --> https://bugs.webkit.org/attachment.cgi?id=414286
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414286&action=review

> Source/WebCore/platform/graphics/MediaPlayer.cpp:-480
> -    m_contentType = contentType;

Is this really not needed if we end up in `nextBestMediaEngine`?

> Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp:61
> +    return { };

You could call `notImplemented()` from all of these stub methods.

> Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp:62
> +}

Ditto

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:637
> +    if (m_remoteEngineIdentifier ==
MediaPlayerEnums::MediaEngineIdentifier::AVFoundationMSE) {
> +	   auto identifier = RemoteMediaSourceIdentifier::generate();
> +	  
connection().send(Messages::RemoteMediaPlayerProxy::LoadMediaSource(url,
identifier), m_id);
> +	   m_mediaSourcePrivate =
MediaSourcePrivateRemote::create(m_manager.gpuProcessConnection(), identifier,
m_manager.typeCache(m_remoteEngineIdentifier), *this, client);
> +    } else {

You could use an early return here instead of the `else`

> Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp:107
> +}

notImplemented()

> Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:85
> +}

Ditto