[webkit-reviews] review granted: [Bug 218967] PCM: Change attribute and JSON key names according to the W3C conversation : [Attachment 414268] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 218967: PCM: Change attribute and JSON key names according to the W3C
conversation
https://bugs.webkit.org/show_bug.cgi?id=218967

Attachment 414268: Patch

https://bugs.webkit.org/attachment.cgi?id=414268&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 414268
  --> https://bugs.webkit.org/attachment.cgi?id=414268
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414268&action=review

Looks good. Nice to have the spec coming together! r=me.

> Source/WebCore/ChangeLog:8
> +	   Weâve discussed extensively with Google and others on naming for the
link

Looks like you got a smart-quote in here.

> Source/WebCore/html/HTMLAnchorElement.cpp:426
> +	   document().addConsoleMessage(MessageSource::Other,
MessageLevel::Warning, "Both attributionsourceid and attributeon need to be set
for Private Click Measurement to work."_s);

I know that this is correct, but at first I thought "attributeon" was
misspelled.

> Source/WebCore/html/HTMLAttributeNames.in:70
> +attributeon

I wish this had been spec'd as "attribute-on"