[webkit-reviews] review granted: [Bug 218381] [WTF] Coding style issues in MediaTime.h : [Attachment 414252] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 16 11:06:19 PST 2020


Alex Christensen <achristensen at apple.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 218381: [WTF] Coding style issues in MediaTime.h
https://bugs.webkit.org/show_bug.cgi?id=218381

Attachment 414252: Patch

https://bugs.webkit.org/attachment.cgi?id=414252&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 414252
  --> https://bugs.webkit.org/attachment.cgi?id=414252
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414252&action=review

> Source/WTF/wtf/MediaTime.h:74
> +    inline bool operator<(const MediaTime& rhs) const { return compare(rhs)
== LessThan; }

here either.

> Source/WTF/wtf/MediaTime.h:92
> +    inline bool isValid() const { return m_timeFlags & Valid; }

ditto

> Source/WTF/wtf/MediaTime.h:107
> +    inline const int64_t& timeValue() const { return m_timeValue; }

ditto


More information about the webkit-reviews mailing list