[webkit-reviews] review granted: [Bug 218982] [macOS] The WebContent sandbox does not apply for open source builds : [Attachment 414232] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 16 09:27:50 PST 2020


Alexey Proskuryakov <ap at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 218982: [macOS] The WebContent sandbox does not apply for open source
builds
https://bugs.webkit.org/show_bug.cgi?id=218982

Attachment 414232: Patch

https://bugs.webkit.org/attachment.cgi?id=414232&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 414232
  --> https://bugs.webkit.org/attachment.cgi?id=414232
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414232&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:115
> +#if USE(APPLE_INTERNAL_SDK) && __MAC_OS_X_VERSION_MIN_REQUIRED > 110000

It may be nicer to add and use HAVE(SANDBOX_MESSAGE_FILTERING) instead of
version checks everywhere.


More information about the webkit-reviews mailing list