[webkit-reviews] review granted: [Bug 210302] Add support for the Wasm sign-extension-ops proposal : [Attachment 414173] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 16 08:43:05 PST 2020


Yusuke Suzuki <ysuzuki at apple.com> has granted Sergey Rubanov
<chi187 at gmail.com>'s request for review:
Bug 210302: Add support for the Wasm sign-extension-ops proposal
https://bugs.webkit.org/show_bug.cgi?id=210302

Attachment 414173: Patch

https://bugs.webkit.org/attachment.cgi?id=414173&action=review




--- Comment #11 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 414173
  --> https://bugs.webkit.org/attachment.cgi?id=414173
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414173&action=review

r=me Nice.

> Source/JavaScriptCore/ChangeLog:3
> +	   Add support for the Wasm sign-extension-ops proposal

Can you change the bug title + ChangeLog titles to clarify this implements i32
sign-extension-ops and it is not including i64 ops?
And, can you open a bug for i64 sign-extension-ops, and change
JSTests/wasm/spec-tests/i64.wast.js's URL to the new one?


More information about the webkit-reviews mailing list