[webkit-reviews] review granted: [Bug 218956] TextEncoderStreamEncoder should not be exposed : [Attachment 414168] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 218956: TextEncoderStreamEncoder should not be exposed
https://bugs.webkit.org/show_bug.cgi?id=218956

Attachment 414168: Patch

https://bugs.webkit.org/attachment.cgi?id=414168&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 414168
  --> https://bugs.webkit.org/attachment.cgi?id=414168
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414168&action=review

r=me

> Source/WebCore/bindings/scripts/test/JS/JSDOMWindow.cpp:206
> +    if
((jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecutionContext()->isSecur
eContext() &&
TestEnabledForContext::enabledForContext(*jsCast<JSDOMGlobalObject*>(globalObje
ct())->scriptExecutionContext()))) {

Looks like we need to remove this brace.

> Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:248
> +    if
(downcast<Document>(jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecution
Context())->settings().testSettingEnabled()) {

Ditto about the brace.

> Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:251
> +    if
(downcast<Document>(jsCast<JSDOMGlobalObject*>(globalObject())->scriptExecution
Context())->settings().testSettingEnabled()) {

Ditto.

> Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp:717
> +    if (RuntimeEnabledFeatures::sharedFeatures().testFeatureEnabled()) {

Ditto.