[webkit-reviews] review granted: [Bug 218879] Add menu support for app highlights for books : [Attachment 414111] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 218879: Add menu support for app highlights for books
https://bugs.webkit.org/show_bug.cgi?id=218879

Attachment 414111: Patch

https://bugs.webkit.org/attachment.cgi?id=414111&action=review




--- Comment #11 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 414111
  --> https://bugs.webkit.org/attachment.cgi?id=414111
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414111&action=review

> Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:60
> +    WebKitLegacy:

This and WebCore: are probably not necessary, since it's only exposed in
WebKit.

> Source/WebCore/page/ContextMenuController.cpp:465
> +	   // TODO: Add Highlight Logic

I think WebKit style prefers FIXME over TODO.