[webkit-reviews] review denied: [Bug 218885] [WASM-References] Remove subtyping rule for externref and funcref : [Attachment 414003] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 14 02:03:00 PST 2020


Yusuke Suzuki <ysuzuki at apple.com> has denied Dmitry <dbezhetskov at igalia.com>'s
request for review:
Bug 218885: [WASM-References] Remove subtyping rule for externref and funcref
https://bugs.webkit.org/show_bug.cgi?id=218885

Attachment 414003: Patch

https://bugs.webkit.org/attachment.cgi?id=414003&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 414003
  --> https://bugs.webkit.org/attachment.cgi?id=414003
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414003&action=review

The design looks good. Can you check JSC test failure?

> Source/JavaScriptCore/wasm/WasmFormat.h:81
> +inline bool isSubtype(Type sub, Type parent) { return sub == parent; }

Let's remove this function since `sub == parent` is the same type.


More information about the webkit-reviews mailing list