[webkit-reviews] review granted: [Bug 218915] [LFC][Integration] Use the physical size when setting the pre-computed width/height on ReplacedBox : [Attachment 414061] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 218915: [LFC][Integration] Use the physical size when setting the
pre-computed width/height on ReplacedBox
https://bugs.webkit.org/show_bug.cgi?id=218915

Attachment 414061: Patch

https://bugs.webkit.org/attachment.cgi?id=414061&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 414061
  --> https://bugs.webkit.org/attachment.cgi?id=414061
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414061&action=review

> Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:126
> +    updateReplacedDimensions(inlineBlock)

Might be nicer to have a private shared function
(updateReplacedOrInlineBlockDimensions or similar)