[webkit-reviews] review granted: [Bug 218333] Final refactor for WebGL implementation to use only GraphicsContextGL : [Attachment 414030] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 218333: Final refactor for WebGL implementation to use only
GraphicsContextGL
https://bugs.webkit.org/show_bug.cgi?id=218333

Attachment 414030: Patch

https://bugs.webkit.org/attachment.cgi?id=414030&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 414030
  --> https://bugs.webkit.org/attachment.cgi?id=414030
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414030&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1790
> +   
static_cast<GraphicsContextGLOpenGL*>(m_context.get())->compressedTexImage2D(ta
rget, level, internalformat, width, height,

I think you should add SPECIALIZE_TYPE_TRAITS macros and use downcast<> for all
these casts.