[webkit-reviews] review granted: [Bug 218902] Add support for discrete animations of many CSS properties : [Attachment 414044] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 218902: Add support for discrete animations of many CSS properties
https://bugs.webkit.org/show_bug.cgi?id=218902

Attachment 414044: Patch

https://bugs.webkit.org/attachment.cgi?id=414044&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 414044
  --> https://bugs.webkit.org/attachment.cgi?id=414044
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414044&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:1917
>	   new DiscretePropertyWrapper<const
StyleContentAlignmentData&>(CSSPropertyAlignContent,
&RenderStyle::alignContent, &RenderStyle::setAlignContent),
>	   new DiscretePropertyWrapper<const
StyleSelfAlignmentData&>(CSSPropertyAlignItems, &RenderStyle::alignItems,
&RenderStyle::setAlignItems),
>	   new DiscretePropertyWrapper<const
StyleSelfAlignmentData&>(CSSPropertyAlignSelf, &RenderStyle::alignSelf,
&RenderStyle::setAlignSelf),
> +	   new
DiscretePropertyWrapper<BackfaceVisibility>(CSSPropertyWebkitBackfaceVisibility
, &RenderStyle::backfaceVisibility, &RenderStyle::setBackfaceVisibility),

Maybe this stuff should be generated from CSSProperties.json?