[webkit-reviews] review granted: [Bug 213016] [buildbot] Add buildAndTest bot for WebKitGTK (GTK4) : [Attachment 414005] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Diego Pino
<dpino at igalia.com>'s request for review:
Bug 213016: [buildbot] Add buildAndTest bot for WebKitGTK (GTK4)
https://bugs.webkit.org/show_bug.cgi?id=213016

Attachment 414005: Patch

https://bugs.webkit.org/attachment.cgi?id=414005&action=review




--- Comment #6 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 414005
  --> https://bugs.webkit.org/attachment.cgi?id=414005
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414005&action=review

> Tools/CISupport/build-webkit-org/factories.py:179
> +class BuildAndTestAllButJSCFactory(TestAllButJSCFactory):
> +    def getProduct(self):
> +	   self.addStep(CompileWebKit())

instead of inheriting from TestAllButJSCFactory and re-defining getProduct I
would do this instead:

class BuildAndTestAllButJSCFactory(BuildAndTestFactory):
    JSCTestClass = None