[webkit-reviews] review granted: [Bug 218686] Web Inspector: ensure that `JSON::ArrayOf<T>` doesn't allow `addItem` to be called with a type other than `T` : [Attachment 413563] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 218686: Web Inspector: ensure that `JSON::ArrayOf<T>` doesn't allow
`addItem` to be called with a type other than `T`
https://bugs.webkit.org/show_bug.cgi?id=218686

Attachment 413563: Patch

https://bugs.webkit.org/attachment.cgi?id=413563&action=review




--- Comment #4 from Brian Burg <bburg at apple.com> ---
Comment on attachment 413563
  --> https://bugs.webkit.org/attachment.cgi?id=413563
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413563&action=review

r=me

>
Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator_templates.py:142
> +    static NeverDestroyed<DispatchMap> dispatchMap = DispatchMap({

��

>
Source/JavaScriptCore/inspector/scripts/tests/expected/domains-with-varying-com
mand-sizes.json-result:342
> +    static NeverDestroyed<DispatchMap> dispatchMap = DispatchMap({

Ugh, you are the best, Devin! This is so much nicer.