[webkit-reviews] review granted: [Bug 218825] [GPUProcess] Add basic GPUProcess crash handling for media playback : [Attachment 413969] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 218825: [GPUProcess] Add basic GPUProcess crash handling for media playback
https://bugs.webkit.org/show_bug.cgi?id=218825

Attachment 413969: Patch

https://bugs.webkit.org/attachment.cgi?id=413969&action=review




--- Comment #14 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 413969
  --> https://bugs.webkit.org/attachment.cgi?id=413969
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413969&action=review

Thanks Chris!

>> Source/WebCore/platform/graphics/MediaPlayer.cpp:735
>> +void MediaPlayer::seekWhenPossible(const MediaTime& time)
> 
> Maybe I could merge this logic into seek() instead of adding this new
function. I went the conservative way with this new function but I can try
tweaking seek() instead if media people think it would be better.

I think having this a a separate function is fine.