[webkit-reviews] review granted: [Bug 218840] REGRESSION(r269701): inspector/console/webcore-logging.html is crashing : [Attachment 413906] Speculative fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 11 22:34:25 PST 2020


Devin Rousso <drousso at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 218840: REGRESSION(r269701): inspector/console/webcore-logging.html is
crashing
https://bugs.webkit.org/show_bug.cgi?id=218840

Attachment 413906: Speculative fix

https://bugs.webkit.org/attachment.cgi?id=413906&action=review




--- Comment #7 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 413906
  --> https://bugs.webkit.org/attachment.cgi?id=413906
Speculative fix

rs=me

Should we also guard the `evaluateQueuedExpressions()` call inside
`InspectorFrontendAPIDispatcher::unsuspend` behind an `if (m_frontendLoaded)`?


More information about the webkit-reviews mailing list