[webkit-reviews] review requested: [Bug 218678] Web Inspector: drop `shown`/`hidden` in favor of `attached`/`detached` : [Attachment 413891] [Patch] WIP

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 11 17:43:32 PST 2020

Devin Rousso <drousso at apple.com> has asked  for review:
Bug 218678: Web Inspector: drop `shown`/`hidden` in favor of

Attachment 413891: [Patch] WIP


--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Created attachment 413891

  --> https://bugs.webkit.org/attachment.cgi?id=413891&action=review

[Patch] WIP

Fixed an issue I just discovered where switching to the Console Tab when the
split console is showing caused the split console to always appear blank.  This
happens because the `WI.ConsoleDrawer` is never removed from the DOM even when
hidden, meaning that `detached` is never called on it's
`WI.ContentViewContainer` which is what's responsible for hiding all of the
entries in the back/forward list and therefore when the `WI.consoleContentView`
is re-shown (via `showContentView`) it matches the current item in the
back/forward list and is not re-added.	Changed `WI.ConsoleDrawer.prototype.set
collapsed` to manually call `attached`/`detached`.

Alongside this, I also added a fix/drive-by for re-showing the split console
when switching away from the Console Tab if the split console was previously

More information about the webkit-reviews mailing list