[webkit-reviews] review granted: [Bug 218730] PCM: Change from ad-click-attribution to private-click-measurement (in all forms, including .well-known URL) : [Attachment 413868] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 218730: PCM: Change from ad-click-attribution to private-click-measurement
(in all forms, including .well-known URL)
https://bugs.webkit.org/show_bug.cgi?id=218730

Attachment 413868: Patch

https://bugs.webkit.org/attachment.cgi?id=413868&action=review




--- Comment #17 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 413868
  --> https://bugs.webkit.org/attachment.cgi?id=413868
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413868&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h:37
>  WK_EXTERN NSString * const _WKWebsiteDataTypeAdClickAttributions
WK_API_AVAILABLE(macos(10.15), ios(13.0));

We should deprecate this now or soonish.  Deprecating now would require
ignoring deprecation warnings in Safari before landing this.