[webkit-reviews] review granted: [Bug 218816] Add minimal support for deep color IOSurface backing store to ImageBuffer : [Attachment 413872] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 218816: Add minimal support for deep color IOSurface backing store to
ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=218816

Attachment 413872: Patch

https://bugs.webkit.org/attachment.cgi?id=413872&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 413872
  --> https://bugs.webkit.org/attachment.cgi?id=413872
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413872&action=review

> Source/WebCore/platform/graphics/ImageBufferBackend.h:57
>  enum class ColorFormat : uint8_t {

Rename to PixelFormat (and rename all the arguments everywhere?)

> Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.cpp:82
> +	   auto context = adoptCF(CGBitmapContextCreate(0, logicalSize.width(),
logicalSize.height(), 8, 4 * logicalSize.width(), sRGBColorSpaceRef(),
kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host));

kCGBitmapByteOrder32Host is always BGRA?