[webkit-reviews] review granted: [Bug 218788] [Media in GPU Process] Update RemoteMediaPlayerMIMETypeCache to add the support for AVFoundationMSE media engine : [Attachment 413840] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 11 12:02:28 PST 2020


Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 218788: [Media in GPU Process] Update RemoteMediaPlayerMIMETypeCache to add
the support for AVFoundationMSE media engine
https://bugs.webkit.org/show_bug.cgi?id=218788

Attachment 413840: Patch

https://bugs.webkit.org/attachment.cgi?id=413840&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 413840
  --> https://bugs.webkit.org/attachment.cgi?id=413840
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413840&action=review

> Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerMIMETypeCache.cpp:59
> +	   for (auto& type : types)
> +	       m_supportedTypesCache.add(type);

You can call addSupportedTypes().

>> Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:-125
>> -void RemoteMediaPlayerManager::initialize(const
WebProcessCreationParameters& parameters)
> 
> Eric, do we need to keep this function?

We definitely want to cache WebProcessCreationParameters.mediaMIMETypes so we
don't have to ask AVFoundation for MIME types more than once in the life of the
host application.


More information about the webkit-reviews mailing list