[webkit-reviews] review canceled: [Bug 218745] [css-flex] Better naming from some methods : [Attachment 413684] Patch

[bugzilla-daemon at webkit.org]

Javier Fernandez <jfernandez at igalia.com> has canceled Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 218745: [css-flex] Better naming from some methods
https://bugs.webkit.org/show_bug.cgi?id=218745

Attachment 413684: Patch

https://bugs.webkit.org/attachment.cgi?id=413684&action=review




--- Comment #4 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 413684
  --> https://bugs.webkit.org/attachment.cgi?id=413684
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413684&action=review

>>> Source/WebCore/rendering/RenderFlexibleBox.cpp:390
>>>  {
>> 
>> I'm not totally sure about this change. Somehow, we are using a different
concept here; flow vs size. 
>> 
>> What about mainAxisFlowIsChildBlockFlow using the concepts used in the CSS
Logical Prooperties [1] about the flow-relative dimensions, based on the
Writing Modes terminology [2]
>> 
>> ]1] https://www.w3.org/TR/css-logical-1/#directional-keywords
>> [2] https://www.w3.org/TR/css-writing-modes-4/#block-flow
> 
> Makes sense. What about mainAxisIsChildInlineAxis() ? Note that I'm changing
the equality bellow, so we no longer check the block but the inline direction.

OK