[webkit-reviews] review granted: [Bug 217218] Refactor VideoTextureCopier to be specific to a particular GraphicsContextGL and polymorphic to it : [Attachment 413789] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 217218: Refactor VideoTextureCopier to be specific to a particular
GraphicsContextGL and polymorphic to it
https://bugs.webkit.org/show_bug.cgi?id=217218

Attachment 413789: Patch

https://bugs.webkit.org/attachment.cgi?id=413789&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 413789
  --> https://bugs.webkit.org/attachment.cgi?id=413789
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413789&action=review

> Source/WebCore/platform/graphics/GraphicsContextGL.h:1300
> +    virtual GraphicsContextGLCV* asCV() = 0;

I wonder if we should just expose copyPixelBufferToTexture on GraphicsContextGL
directly, and have the context keep the GraphicsContextGLCV class for internal
use?