[webkit-reviews] review canceled: [Bug 218515] Web Inspector: Underline active font-face(s) in Elements sidebar Styles panel : [Attachment 413771] WIP

[bugzilla-daemon at webkit.org]

Patrick Angle <pangle at apple.com> has canceled Patrick Angle
<pangle at apple.com>'s request for review:
Bug 218515: Web Inspector: Underline active font-face(s) in Elements sidebar
Styles panel
https://bugs.webkit.org/show_bug.cgi?id=218515

Attachment 413771: WIP

https://bugs.webkit.org/attachment.cgi?id=413771&action=review




--- Comment #21 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 413771
  --> https://bugs.webkit.org/attachment.cgi?id=413771
WIP

This is a major WIP based on Myles' review notes. It is mostly functional, but
suffers from an issue where a `FontRanges::Range` can end up being destroyed
and recreated at a different address when another `FontRanges::Range` is
appended to a `FontRanges`. This complicates the storage of extra data we need
as part of a GlyphData because GlyphData is not necessarily the authority of
which font gets used for a glyph. During layout in `ComplexTextController`
(actually `ComplexTextControllerCoreText.mm`) the entire character can be
thrown out and recalculated as part of the fallback mechanism (even though
those mechanisms should not be necessary since earlier font resolution should
already have chosen a fallback).