[webkit-reviews] review granted: [Bug 218730] PCM: Change from ad-click-attribution to private-click-measurement (in all forms, including .well-known URL) : [Attachment 413745] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 218730: PCM: Change from ad-click-attribution to private-click-measurement
(in all forms, including .well-known URL)
https://bugs.webkit.org/show_bug.cgi?id=218730

Attachment 413745: Patch

https://bugs.webkit.org/attachment.cgi?id=413745&action=review




--- Comment #9 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 413745
  --> https://bugs.webkit.org/attachment.cgi?id=413745
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413745&action=review

r=me with a few remaining fixes

> Source/JavaScriptCore/ChangeLog:20023
> -	    - `AdClickAttributionDebugModeEnabled`
> +	    - `PrivateClickMeasurementDebugModeEnabled`

I don't think we should modify old ChangeLog entries

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:-101
> -localizedStrings["Ad Click Attribution Debug Mode"] = "Ad Click Attribution
Debug Mode";

this shouldn't be removed since it's still used in
`Source/WebInspectorUI/UserInterface/Base/Main.js`

> Source/WebInspectorUI/UserInterface/Base/Main.js:2349
> +		       {name: WI.UIString("Ad Click Attribution Debug Mode"),
setting: InspectorBackend.Enum.Page.Setting.AdClickAttributionDebugModeEnabled,
value: true},		     ],

Style: the `],` should be on a separate line