[webkit-reviews] review granted: [Bug 218733] REGRESSION (r269525): Many layout tests crash when run under ASan : [Attachment 413715] roundUpToMultipleOf + remove some reinterpret_casts

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 218733: REGRESSION (r269525): Many layout tests crash when run under ASan
https://bugs.webkit.org/show_bug.cgi?id=218733

Attachment 413715: roundUpToMultipleOf + remove some reinterpret_casts

https://bugs.webkit.org/attachment.cgi?id=413715&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 413715
  --> https://bugs.webkit.org/attachment.cgi?id=413715
roundUpToMultipleOf + remove some reinterpret_casts

View in context: https://bugs.webkit.org/attachment.cgi?id=413715&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp:558
> +    auto itemLocation = destination.data + sizeof(uint64_t);

offset?

> Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.h:80
> -	   return *reinterpret_cast<T*>(&data[sizeof(ItemType)]);
> +	   return *reinterpret_cast<T*>(&data[sizeof(uint64_t)]);

Didn't want to just inflate ItemType? I guess that's OK