[webkit-reviews] review granted: [Bug 218732] Fix for LayoutTests/accessibility/mac/search-predicate.html in isolated tree mode. : [Attachment 413690] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 218732: Fix for LayoutTests/accessibility/mac/search-predicate.html in
isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=218732

Attachment 413690: Patch

https://bugs.webkit.org/attachment.cgi?id=413690&action=review




--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 413690
  --> https://bugs.webkit.org/attachment.cgi?id=413690
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413690&action=review

> Source/WebCore/ChangeLog:11
> +	   - Added handling of "AXIsOnScreen" attribute to
WebAccessibilityOobjectWrapperMac.

Spelling error here

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:506
> +    bool isVisible() const override { return
boolAttributeValue(AXPropertyName::IsVisible); }

If we cache this we’ll need to update this value on objects after a scroll
event right?