[webkit-reviews] review granted: [Bug 218738] Use GraphicsContext instead of CGContext in RemoteLayerBackingStore : [Attachment 413668] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 9 23:07:13 PST 2020

Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 218738: Use GraphicsContext instead of CGContext in RemoteLayerBackingStore

Attachment 413668: Patch


--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 413668
  --> https://bugs.webkit.org/attachment.cgi?id=413668

View in context: https://bugs.webkit.org/attachment.cgi?id=413668&action=review

> Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:272
> +void RemoteLayerBackingStore::drawInContext(WebCore::GraphicsContext&
context, RefPtr<WebCore::NativeImage> backImage)

Nit - I think we generally RefPtr<>&& these, so that we can use move semantics
from the call site if possible.

More information about the webkit-reviews mailing list