[webkit-reviews] review granted: [Bug 218727] Add support for AudioConfiguration.spatialRendering : [Attachment 413636] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 218727: Add support for AudioConfiguration.spatialRendering
https://bugs.webkit.org/show_bug.cgi?id=218727

Attachment 413636: Patch

https://bugs.webkit.org/attachment.cgi?id=413636&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 413636
  --> https://bugs.webkit.org/attachment.cgi?id=413636
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413636&action=review

> Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:42
> +    : m_context(context)

WTFMove(context)

> Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:90
> +	   if (auto* outputDevice = [m_context outputDevice])

Nit: '*' on the wrong side.

> Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:95
> +    auto* avOutputDevices = [m_context outputDevices];

Ditto

> Source/WebCore/PAL/pal/avfoundation/OutputDevice.mm:47
> +uint8_t OutputDevice::deviceFeatures() const

You could use std::bitset<>