[webkit-reviews] review granted: [Bug 218437] Parse aspect-ratio CSS property : [Attachment 413145] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 218437: Parse aspect-ratio CSS property
https://bugs.webkit.org/show_bug.cgi?id=218437

Attachment 413145: Patch

https://bugs.webkit.org/attachment.cgi?id=413145&action=review




--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 413145
  --> https://bugs.webkit.org/attachment.cgi?id=413145
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413145&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:3941
> +	   return autoValue;

Since the types don’t match here (CSSValue vs. CSSPrimitiveValue), this should
be WTFMove(autoValue).

> Source/WebCore/css/parser/CSSPropertyParser.cpp:3943
> +    RefPtr<CSSPrimitiveValue> leftValue = consumeNumber(range,
ValueRangeNonNegative);

auto

> Source/WebCore/css/parser/CSSPropertyParser.cpp:3949
> +    RefPtr<CSSPrimitiveValue> rightValue = consumeNumber(range,
ValueRangeNonNegative);

auto

> Source/WebCore/rendering/style/RenderStyle.h:1015
> +    void setAspectRatio(FloatSize v) { SET_VAR(m_rareNonInheritedData,
aspectRatio, v); }

Maybe const FloatSize&? Not sure if it matters.

> Source/WebCore/style/StyleBuilderCustom.h:1239
> +	   const auto& ratioList = downcast<CSSValueList>(list.item(1));

I think this should be auto, not const auto&.