[webkit-reviews] review granted: [Bug 218677] Unexpose obsolete HTMLAppletElement interface : [Attachment 413615] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 9 13:36:17 PST 2020
Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 218677: Unexpose obsolete HTMLAppletElement interface
https://bugs.webkit.org/show_bug.cgi?id=218677
Attachment 413615: Patch
https://bugs.webkit.org/attachment.cgi?id=413615&action=review
--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 413615
--> https://bugs.webkit.org/attachment.cgi?id=413615
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=413615&action=review
I suspect there is a bit more that can be removed afterwards.
> Source/WebCore/html/HTMLPlugInImageElement.h:32
> +// Base class for HTMLEmbedElement, and HTMLObjectElement.
Should remove the "," here.
> Source/WebCore/html/HTMLTagNames.in:11
> +applet interfaceName=HTMLUnknownElement
Why do we need this? What is the benefit over just removing the tag name
entirely instead?
>
Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLAppletElementP
rivate.h:20
> #ifndef WebKitDOMHTMLAppletElementPrivate_h
Seems like someone with enough knowledge of how things are used could remove
this entire header instead.
> Source/WebKitLegacy/mac/DOM/DOMHTMLAppletElement.mm:30
> #import <WebCore/HTMLNames.h>
Can remove most of these includes, maybe all.
> LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt:35
> APPLET also has:
Should we change the test to remove this?
More information about the webkit-reviews
mailing list