[webkit-reviews] review requested: [Bug 218695] Show legacy line layout visual coverage instead of "simple line" layout. : [Attachment 413619] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 9 12:40:23 PST 2020


Sam Weinig <sam at webkit.org> has asked  for review:
Bug 218695: Show legacy line layout visual coverage instead of "simple line"
layout.
https://bugs.webkit.org/show_bug.cgi?id=218695

Attachment 413619: Patch

https://bugs.webkit.org/attachment.cgi?id=413619&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 413619
  --> https://bugs.webkit.org/attachment.cgi?id=413619
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413619&action=review

> Source/WTF/ChangeLog:8
> +	   * Scripts/Preferences/WebPreferencesDebug.yaml:

I feel like maybe we should merge Debug and Internal preferences, as it seems
silly to need to need to do all this plumbing to have the settings show up in
minibrowser. Do you use the Debug nature of the setting (e.g. that it can be
set globally for any WKWebView)?


More information about the webkit-reviews mailing list