[webkit-reviews] review granted: [Bug 210476] Scroll-snap on the root aligns to the body margin edge, not the viewport edge : [Attachment 413602] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 210476: Scroll-snap on the root aligns to the body margin edge, not the
viewport edge
https://bugs.webkit.org/show_bug.cgi?id=210476

Attachment 413602: Patch

https://bugs.webkit.org/attachment.cgi?id=413602&action=review




--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 413602
  --> https://bugs.webkit.org/attachment.cgi?id=413602
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413602&action=review

>
LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe
-horizontal-with-margin.html:112
> +		   message.innerHTML = "<p>This test is better run under
DumpRenderTree. To manually test it, place the mouse pointer<br/>"
> +		       + "inside the red region at the top of the page, and
then use the mouse wheel or a two-finger swipe to make a<br/>"
> +		       + "small swipe gesture with some momentum.<br/><br/>"
> +		       + "The region should scroll to show a green
region.<br/><br/>"
> +		       + "Next, perform a small scroll gesture that does not
involve momentum. You should begin to see one of the colors<br/>"
> +		       + "to the left (or right) of the current green box. When
you release the wheel, the region should scroll back so<br/>"
> +		       + "that the region is a single color.<br/><br/>"
> +		       + "You should also be able to repeat these test steps
for the vertical region below.</p>";

Personally I hate these long descriptions as they are often wrong.