[webkit-reviews] review granted: [Bug 218706] [build.webkit.org] Add python 3 support - part 3 : [Attachment 413582] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 9 08:30:35 PST 2020


Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 218706: [build.webkit.org] Add python 3 support - part 3
https://bugs.webkit.org/show_bug.cgi?id=218706

Attachment 413582: Patch

https://bugs.webkit.org/attachment.cgi?id=413582&action=review




--- Comment #3 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 413582
  --> https://bugs.webkit.org/attachment.cgi?id=413582
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413582&action=review

> Tools/CISupport/build-webkit-org/loadConfig.py:-189
> -    keywords = filter(None, re.split('[, \-_:()]+', str(builder['name'])))

Seems like code that results in the what the original code is would be:

keywords = re.split('[, \-_:()]+', str(builder['name'])) or None

But it likely doesn't matter.


More information about the webkit-reviews mailing list