[webkit-reviews] review granted: [Bug 218690] [LFC][Integration] Cleanup LayoutIntegration::Line interface : [Attachment 413536] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 7 23:42:25 PST 2020

Daniel Bates <dbates at webkit.org> has granted zalan <zalan at apple.com>'s request
for review:
Bug 218690: [LFC][Integration] Cleanup LayoutIntegration::Line interface

Attachment 413536: Patch


--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 413536
  --> https://bugs.webkit.org/attachment.cgi?id=413536

View in context: https://bugs.webkit.org/attachment.cgi?id=413536&action=review

> Source/WebCore/layout/inlineformatting/InlineLineGeometry.h:38
> +    InlineLineGeometry(const InlineRect& lineLogicalRect, const
InlineLayoutSize& lineBoxLogicalSize, InlineLayoutUnit aligmentBaseline,
InlineLayoutUnit horizontalAlignmentOffset);

Ok as-is. Consider removing names for first 2 params now that they have
different types.

More information about the webkit-reviews mailing list