[webkit-reviews] review granted: [Bug 216727] [GTK] REGRESSION(r267250) API test /webkit/WebKitWebView/usermedia-enumeratedevices-permission-check is crashing : [Attachment 413431] Updated using dispose

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Lauro Moura
<lmoura at igalia.com>'s request for review:
Bug 216727: [GTK] REGRESSION(r267250) API test
/webkit/WebKitWebView/usermedia-enumeratedevices-permission-check is crashing
https://bugs.webkit.org/show_bug.cgi?id=216727

Attachment 413431: Updated using dispose

https://bugs.webkit.org/attachment.cgi?id=413431&action=review




--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 413431
  --> https://bugs.webkit.org/attachment.cgi?id=413431
Updated using dispose

View in context: https://bugs.webkit.org/attachment.cgi?id=413431&action=review

> Source/WebKit/ChangeLog:16
> +	   (webkit_geolocation_manager_class_init): Register dispose CB.

Don't use abbreviations, I guess CB means callback in this case?

> Source/WebKit/UIProcess/API/glib/WebKitGeolocationManager.cpp:336
> +    if (manager->priv->manager)
> +	   manager->priv->manager->setProvider(nullptr);

How can be manager->priv->manager nullptr at this point? we take a reference on
construction.