[webkit-reviews] review granted: [Bug 218479] [WebAuthn] [iOS] WebAuthn process doesn't start on iOS devices : [Attachment 413387] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 218479: [WebAuthn] [iOS] WebAuthn process doesn't start on iOS devices
https://bugs.webkit.org/show_bug.cgi?id=218479

Attachment 413387: Patch

https://bugs.webkit.org/attachment.cgi?id=413387&action=review




--- Comment #9 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 413387
  --> https://bugs.webkit.org/attachment.cgi?id=413387
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413387&action=review

Can you please file a radar to audit the sandbox? I think both WebAuthn
sandoxes contain tons of stuff we don't need, and we should clean that up
before we turn this on for people. But r=me for this work in progress.

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb:111
> +	      (xpc-service-name "com.apple.audio.toolbox.reporting.service")))

I'll bet we don't need "play-audio"

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb:189
> +)

I'll bet we don't need this "play-media" bit at all.