[webkit-reviews] review granted: [Bug 218588] Add new display list item types in preparation for webkit.org/b/218426 : [Attachment 413478] Rename + add FIXME

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 218588: Add new display list item types in preparation for
webkit.org/b/218426
https://bugs.webkit.org/show_bug.cgi?id=218588

Attachment 413478: Rename + add FIXME

https://bugs.webkit.org/attachment.cgi?id=413478&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 413478
  --> https://bugs.webkit.org/attachment.cgi?id=413478
Rename + add FIXME

View in context: https://bugs.webkit.org/attachment.cgi?id=413478&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp:238
> +	   get<MetaCommandSwitchTo>().apply(context);

Or not?

> Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:988
> +    // Handled by client.

Can't we flush via GraphicsContext?

> Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:999
> +    // Handled by client.

ASSERT_NOT_REACHED()?