[webkit-reviews] review granted: [Bug 218657] [macOS] Add IOKIt message filtering : [Attachment 413465] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 6 12:44:11 PST 2020
Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 218657: [macOS] Add IOKIt message filtering
https://bugs.webkit.org/show_bug.cgi?id=218657
Attachment 413465: Patch
https://bugs.webkit.org/attachment.cgi?id=413465&action=review
--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 413465
--> https://bugs.webkit.org/attachment.cgi?id=413465
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=413465&action=review
I had a few questions, but looks good. r=me
> Source/WebKit/ChangeLog:9
> + Like on iOS, the WebContent process on macOS should have IOKit
message filtering as well.
No need for "as well" at the end (since you say "Like on iOS, ...")
> Source/WebKit/ChangeLog:15
> + * WebProcess/com.apple.WebProcess.sb.in:
Should we be making similar changes to the GPU Process sandbox?
> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-139
> - (iokit-registry-entry-class "AppleGraphicsControlClient")
So we do NOT need AppleGraphicsControlClient?
More information about the webkit-reviews
mailing list