[webkit-reviews] review granted: [Bug 217156] Text gets clobbered when assigning to input.defaultValue : [Attachment 413447] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 6 11:16:23 PST 2020


Darin Adler <darin at apple.com> has granted Joey Arhar <jarhar at chromium.org>'s
request for review:
Bug 217156: Text gets clobbered when assigning to input.defaultValue
https://bugs.webkit.org/show_bug.cgi?id=217156

Attachment 413447: Patch

https://bugs.webkit.org/attachment.cgi?id=413447&action=review




--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 413447
  --> https://bugs.webkit.org/attachment.cgi?id=413447
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413447&action=review

> LayoutTests/fast/forms/defaultValue-clobbering.html:12
> +shouldBeFalse('numberinput.validity.valid');

Do we also want to check the value, not just the validity, of the input element
here?


More information about the webkit-reviews mailing list