[webkit-reviews] review granted: [Bug 217482] [GTK] Crash in WebKit::DropTarget::drop : [Attachment 413415] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 217482: [GTK] Crash in WebKit::DropTarget::drop
https://bugs.webkit.org/show_bug.cgi?id=217482

Attachment 413415: Patch

https://bugs.webkit.org/attachment.cgi?id=413415&action=review




--- Comment #9 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 413415
  --> https://bugs.webkit.org/attachment.cgi?id=413415
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413415&action=review

> Source/WebKit/ChangeLog:9
> +	   accept() to receive the drop context and position to ne set after
leaving any previous operation.

ne -> be

> Source/WebKit/UIProcess/API/gtk/DropTargetGtk3.cpp:262
> +    // If we don't have data at this point, let leave continue.

If I understand this correctly, then how about: "If we don't have data at this
point, allow the leave timer to fire, ending the drop operation."