[webkit-reviews] review granted: [Bug 218638] Event targets should be cleared after dispatch if target pointed to a shadow tree : [Attachment 413429] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 218638: Event targets should be cleared after dispatch if target pointed to
a shadow tree
https://bugs.webkit.org/show_bug.cgi?id=218638

Attachment 413429: Patch

https://bugs.webkit.org/attachment.cgi?id=413429&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 413429
  --> https://bugs.webkit.org/attachment.cgi?id=413429
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413429&action=review

> Source/WebCore/dom/EventDispatcher.cpp:91
> +	       shouldClearTargetsAfterDispatch =
isInShadowTree(eventContext.target()) ||
isInShadowTree(eventContext.relatedTarget());

Is it important to do this shadow tree check before dispatching?