[webkit-reviews] review granted: [Bug 218643] REGRESSION(r268930): It broke the http server of run-benchmark : [Attachment 413428] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 6 08:17:50 PST 2020


Jonathan Bedard <jbedard at apple.com> has granted Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 218643: REGRESSION(r268930): It broke the http server of run-benchmark
https://bugs.webkit.org/show_bug.cgi?id=218643

Attachment 413428: Patch

https://bugs.webkit.org/attachment.cgi?id=413428&action=review




--- Comment #5 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 413428
  --> https://bugs.webkit.org/attachment.cgi?id=413428
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413428&action=review

>
Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_d
river.py:39
> +	   for attempt in range(max_attempt):

While these changes aren't required to fix the regression, they do seem to be
an improvement to readability.


More information about the webkit-reviews mailing list